Skip to content

Commit 5f18058

Browse files
committed
исправил замечания
1 parent c78d08d commit 5f18058

File tree

4 files changed

+27
-27
lines changed

4 files changed

+27
-27
lines changed

src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class ExternalAppStartingDiagnostic extends AbstractFindMethodDiagnostic
5151
"|ПерейтиПоНавигационнойСсылке|GotoURL|ОткрытьНавигационнуюСсылку";
5252
private static final Pattern FULL_PATTERN = CaseInsensitivePattern.compile(
5353
MAIN_PATTERN_STRING + PATTERN_STRING_FOR_NAVI);
54-
private static final boolean CHECK_GOTO_URL = true;
54+
private static final boolean CHECK_GOTO_URL = false;
5555

5656
@DiagnosticParameter(
5757
type = Boolean.class,
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
diagnosticMessage=Check the launch of an external application
22
diagnosticName=External applications starting
33
checkGotoUrl=Check navigation links
4-
userPatternString=User regex pattern
4+
userPatternString=User regex pattern
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
diagnosticMessage=Проверьте запуск внешнего приложения
22
diagnosticName=Запуск внешних приложений
33
checkGotoUrl=Проверять переход по навигационным ссылкам
4-
userPatternString=Пользовательский шаблон (регулярное выражение)
4+
userPatternString=Пользовательский шаблон (регулярное выражение)

src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnosticTest.java

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@ void test() {
4444
.hasRange(9, 4, 23)
4545
.hasRange(10, 4, 23)
4646
.hasRange(12, 4, 26)
47-
.hasRange(14, 4, 32)
48-
.hasRange(15, 26, 52)
49-
.hasRange(16, 26, 52)
47+
5048
.hasRange(18, 26, 44)
5149
.hasRange(19, 26, 44)
5250
.hasRange(20, 20, 38)
@@ -60,38 +58,40 @@ void test() {
6058
.hasRange(54, 4, 20)
6159
.hasRange(55, 4, 20)
6260
.hasRange(56, 4, 20)
63-
.hasSize(19);
61+
.hasSize(16);
6462
}
6563

6664
@Test
6765
void testConfigure_checkGotoUrl() {
6866

6967
Map<String, Object> configuration = diagnosticInstance.info.getDefaultConfiguration();
70-
configuration.put("checkGotoUrl", false);
68+
configuration.put("checkGotoUrl", true);
7169
diagnosticInstance.configure(configuration);
7270

7371
List<Diagnostic> diagnostics = getDiagnostics();
7472

7573
assertThat(diagnostics, true)
76-
.hasRange(8, 4, 18)
77-
.hasRange(9, 4, 23)
78-
.hasRange(10, 4, 23)
79-
.hasRange(12, 4, 26)
80-
81-
.hasRange(18, 26, 44)
82-
.hasRange(19, 26, 44)
83-
.hasRange(20, 20, 38)
84-
.hasRange(21, 20, 38)
85-
.hasRange(23, 26, 42)
86-
.hasRange(24, 26, 37)
87-
.hasRange(25, 26, 37)
88-
.hasRange(35, 10, 34)
89-
90-
.hasRange(53, 4, 20)
91-
.hasRange(54, 4, 20)
92-
.hasRange(55, 4, 20)
93-
.hasRange(56, 4, 20)
94-
.hasSize(16);
74+
.hasRange(8, 4, 18)
75+
.hasRange(9, 4, 23)
76+
.hasRange(10, 4, 23)
77+
.hasRange(12, 4, 26)
78+
.hasRange(14, 4, 32)
79+
.hasRange(15, 26, 52)
80+
.hasRange(16, 26, 52)
81+
.hasRange(18, 26, 44)
82+
.hasRange(19, 26, 44)
83+
.hasRange(20, 20, 38)
84+
.hasRange(21, 20, 38)
85+
.hasRange(23, 26, 42)
86+
.hasRange(24, 26, 37)
87+
.hasRange(25, 26, 37)
88+
.hasRange(35, 10, 34)
89+
90+
.hasRange(53, 4, 20)
91+
.hasRange(54, 4, 20)
92+
.hasRange(55, 4, 20)
93+
.hasRange(56, 4, 20)
94+
.hasSize(19);
9595
}
9696

9797
@Test

0 commit comments

Comments
 (0)