Кривая реализация анализа проекта при открытии

Author: nixel2007

src/main/java/com/github/_1c_syntax/bsl/languageserver/AnalyzeProjectOnStart.java

@@ -0,0 +1,69 @@
+/*
+ * This file is a part of BSL Language Server.
+ *
+ * Copyright (c) 2018-2022
+ * Alexey Sosnoviy <labotamy@gmail.com>, Nikita Fedkin <nixel2007@gmail.com> and contributors
+ *
+ * SPDX-License-Identifier: LGPL-3.0-or-later
+ *
+ * BSL Language Server is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3.0 of the License, or (at your option) any later version.
+ *
+ * BSL Language Server is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with BSL Language Server.
+ */
+package com.github._1c_syntax.bsl.languageserver;
+
+import com.github._1c_syntax.bsl.languageserver.configuration.LanguageServerConfiguration;
+import com.github._1c_syntax.bsl.languageserver.context.DocumentContext;
+import com.github._1c_syntax.bsl.languageserver.context.events.ServerContextPopulatedEvent;
+import com.github._1c_syntax.bsl.languageserver.providers.DiagnosticProvider;
+import lombok.RequiredArgsConstructor;
+import org.springframework.context.event.EventListener;
+import org.springframework.stereotype.Component;
+
+@Component
+@RequiredArgsConstructor
+public class AnalyzeProjectOnStart {
+
+  private final LanguageServerConfiguration configuration;
+  private final DiagnosticProvider diagnosticProvider;
+  private final WorkDoneProgressHelper workDoneProgressHelper;
+
+  @EventListener
+  public void handleEvent(ServerContextPopulatedEvent event) {
+    if (!configuration.getDiagnosticsOptions().isAnalyzeOnStart()) {
+      return;
+    }
+
+    var serverContext = event.getSource();
+
+    var documentContexts = serverContext.getDocuments().values();
+    var progress = workDoneProgressHelper.createProgress(documentContexts.size(), " files");
+    progress.beginProgress("Analyzing project");
+
+    documentContexts.forEach((DocumentContext documentContext) -> {
+
+      progress.tick();
+
+      var withContent = documentContext.isWithContent();
+      if (!withContent) {
+        documentContext.rebuild();
+      }
+      diagnosticProvider.computeAndPublishDiagnostics(documentContext);
+      if (!withContent) {
+        documentContext.clearSecondaryData();
+      }
+
+    });
+
+    progress.endProgress("Project analyzed");
+  }
+}

src/main/java/com/github/_1c_syntax/bsl/languageserver/BSLTextDocumentService.java

@@ -94,7 +94,9 @@
 
 import java.util.Collections;
 import java.util.List;
+import java.util.Set;
 import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.stream.Collectors;
 
 @Component
@@ -118,6 +120,8 @@ public class BSLTextDocumentService implements TextDocumentService, ProtocolExte
   private final ColorProvider colorProvider;
   private final RenameProvider renameProvider;
 
+  private final Set<DocumentContext> openedDocuments = ConcurrentHashMap.newKeySet();
+
   @Override
   public CompletableFuture<Hover> hover(HoverParams params) {
     var documentContext = context.getDocument(params.getTextDocument().getUri());
@@ -309,6 +313,7 @@ public void didOpen(DidOpenTextDocumentParams params) {
     if (configuration.getDiagnosticsOptions().getComputeTrigger() != ComputeTrigger.NEVER) {
       validate(documentContext);
     }
+    openedDocuments.add(documentContext);
   }
 
   @Override
@@ -333,6 +338,7 @@ public void didClose(DidCloseTextDocumentParams params) {
     if (documentContext == null) {
       return;
     }
+    openedDocuments.remove(documentContext);
 
     documentContext.clearSecondaryData();
 

src/main/java/com/github/_1c_syntax/bsl/languageserver/aop/EventPublisherAspect.java

@@ -24,7 +24,9 @@
 import com.github._1c_syntax.bsl.languageserver.configuration.LanguageServerConfiguration;
 import com.github._1c_syntax.bsl.languageserver.configuration.events.LanguageServerConfigurationChangedEvent;
 import com.github._1c_syntax.bsl.languageserver.context.DocumentContext;
+import com.github._1c_syntax.bsl.languageserver.context.ServerContext;
 import com.github._1c_syntax.bsl.languageserver.context.events.DocumentContextContentChangedEvent;
+import com.github._1c_syntax.bsl.languageserver.context.events.ServerContextPopulatedEvent;
 import com.github._1c_syntax.bsl.languageserver.events.LanguageServerInitializeRequestReceivedEvent;
 import lombok.NoArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
@@ -38,6 +40,8 @@
 import org.springframework.context.ApplicationEventPublisherAware;
 
 import javax.annotation.PreDestroy;
+import java.io.File;
+import java.util.Collection;
 
 /**
  * Аспект подсистемы событий.
@@ -74,6 +78,11 @@ public void documentContextRebuild(JoinPoint joinPoint) {
     publishEvent(new DocumentContextContentChangedEvent((DocumentContext) joinPoint.getThis()));
   }
 
+  @AfterReturning("Pointcuts.isServerContext() && Pointcuts.isPopulateContextCall() && args(files)")
+  public void serverContextPopulated(JoinPoint joinPoint, Collection<File> files) {
+    publishEvent(new ServerContextPopulatedEvent((ServerContext) joinPoint.getThis()));
+  }
+
   @AfterReturning("Pointcuts.isLanguageServer() && Pointcuts.isInitializeCall() && args(initializeParams)")
   public void languageServerInitialize(JoinPoint joinPoint, InitializeParams initializeParams) {
     var event = new LanguageServerInitializeRequestReceivedEvent(

src/main/java/com/github/_1c_syntax/bsl/languageserver/aop/Pointcuts.java

@@ -107,6 +107,14 @@ public void isRebuildCall() {
     // no-op
   }
 
+  /**
+   * Это вызов метода populateContext.
+   */
+  @Pointcut("isBSLLanguageServerScope() && execution(* populateContext(..))")
+  public void isPopulateContextCall() {
+    // no-op
+  }
+
   /**
    * Это вызов метода update.
    */

src/main/java/com/github/_1c_syntax/bsl/languageserver/configuration/diagnostics/DiagnosticsOptions.java

@@ -42,6 +42,7 @@
 @JsonIgnoreProperties(ignoreUnknown = true)
 public class DiagnosticsOptions {
   private ComputeTrigger computeTrigger = ComputeTrigger.ONSAVE;
+  private boolean analyzeOnStart;
   private SkipSupport skipSupport = SkipSupport.NEVER;
   private Mode mode = Mode.ON;
   private boolean ordinaryAppSupport = true;

src/main/java/com/github/_1c_syntax/bsl/languageserver/context/DocumentContext.java

@@ -47,7 +47,9 @@
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 import lombok.Setter;
+import lombok.extern.slf4j.Slf4j;
 import org.antlr.v4.runtime.Token;
+import org.apache.commons.io.FileUtils;
 import org.apache.commons.io.FilenameUtils;
 import org.eclipse.lsp4j.Diagnostic;
 import org.eclipse.lsp4j.Position;
@@ -59,7 +61,10 @@
 
 import javax.annotation.Nullable;
 import javax.annotation.PostConstruct;
+import java.io.File;
+import java.io.IOException;
 import java.net.URI;
+import java.nio.charset.StandardCharsets;
 import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
@@ -75,6 +80,7 @@
 @Component
 @Scope("prototype")
 @RequiredArgsConstructor
+@Slf4j
 public class DocumentContext {
 
   private static final Pattern CONTENT_SPLIT_PATTERN = Pattern.compile("\r?\n|\r");
@@ -87,6 +93,9 @@ public class DocumentContext {
   @Getter
   private int version;
 
+  @Getter
+  private boolean withContent;
+
   @Setter(onMethod = @__({@Autowired}))
   private ServerContext context;
   @Setter(onMethod = @__({@Autowired}))
@@ -269,9 +278,8 @@ public void rebuild(String content, int version) {
     computeLock.lock();
 
     boolean versionMatches = version == this.version && version != 0;
-    boolean contentWasCleared = this.content == null;
 
-    if (versionMatches && !contentWasCleared) {
+    if (versionMatches && withContent) {
       clearDependantData();
       computeLock.unlock();
       return;
@@ -285,13 +293,24 @@ public void rebuild(String content, int version) {
     tokenizer = new BSLTokenizer(content);
     this.version = version;
     symbolTree = computeSymbolTree();
+    withContent = true;
 
     computeLock.unlock();
   }
 
+  public void rebuild() {
+    try {
+      var newContent = FileUtils.readFileToString(new File(uri), StandardCharsets.UTF_8);
+      rebuild(newContent, 0);
+    } catch (IOException e) {
+      LOGGER.error("Can't rebuild content from uri", e);
+    }
+  }
+
   public void clearSecondaryData() {
     computeLock.lock();
 
+    withContent = false;
     content = null;
     contentList.clear();
     tokenizer = null;

src/main/java/com/github/_1c_syntax/bsl/languageserver/context/ServerContext.java

@@ -23,6 +23,7 @@
 
 import com.github._1c_syntax.bsl.languageserver.WorkDoneProgressHelper;
 import com.github._1c_syntax.bsl.languageserver.configuration.LanguageServerConfiguration;
+import com.github._1c_syntax.bsl.languageserver.providers.DiagnosticProvider;
 import com.github._1c_syntax.bsl.languageserver.utils.MdoRefBuilder;
 import com.github._1c_syntax.bsl.languageserver.utils.Resources;
 import com.github._1c_syntax.bsl.types.ModuleType;
@@ -61,6 +62,7 @@ public class ServerContext {
   private final ObjectProvider<DocumentContext> documentContextProvider;
   private final WorkDoneProgressHelper workDoneProgressHelper;
   private final LanguageServerConfiguration languageServerConfiguration;
+  private final DiagnosticProvider diagnosticProvider;
 
   private final Map<URI, DocumentContext> documents = Collections.synchronizedMap(new HashMap<>());
   private final Lazy<Configuration> configurationMetadata = new Lazy<>(this::computeConfigurationMetadata);

src/main/java/com/github/_1c_syntax/bsl/languageserver/context/events/ServerContextPopulatedEvent.java

@@ -0,0 +1,39 @@
+/*
+ * This file is a part of BSL Language Server.
+ *
+ * Copyright (c) 2018-2022
+ * Alexey Sosnoviy <labotamy@gmail.com>, Nikita Fedkin <nixel2007@gmail.com> and contributors
+ *
+ * SPDX-License-Identifier: LGPL-3.0-or-later
+ *
+ * BSL Language Server is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3.0 of the License, or (at your option) any later version.
+ *
+ * BSL Language Server is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with BSL Language Server.
+ */
+package com.github._1c_syntax.bsl.languageserver.context.events;
+
+import com.github._1c_syntax.bsl.languageserver.context.ServerContext;
+import org.springframework.context.ApplicationEvent;
+
+public class ServerContextPopulatedEvent extends ApplicationEvent {
+
+  private static final long serialVersionUID = -4485675935728156708L;
+
+  public ServerContextPopulatedEvent(ServerContext source) {
+    super(source);
+  }
+
+  @Override
+  public ServerContext getSource() {
+    return (ServerContext) super.getSource();
+  }
+}