Skip to content

Commit 6ddc145

Browse files
committed
Updated rubocop + fixed issues
1 parent ba62a16 commit 6ddc145

File tree

4 files changed

+15
-6
lines changed

4 files changed

+15
-6
lines changed

acts_as_recursive_tree.gemspec

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ Gem::Specification.new do |spec|
1616
spec.license = 'MIT'
1717
spec.metadata = {
1818
'bug_tracker_uri' => 'https://github.com/1and1/acts_as_recursive_tree/issues',
19-
'changelog_uri' => 'https://github.com/1and1/acts_as_recursive_tree/blob/main/CHANGELOG.md'
19+
'changelog_uri' => 'https://github.com/1and1/acts_as_recursive_tree/blob/main/CHANGELOG.md',
20+
'rubygems_mfa_required' => 'true'
2021
}
2122
spec.required_ruby_version = '>= 2.5.0'
2223
spec.files = `git ls-files -z`.split("\x0")
@@ -31,9 +32,9 @@ Gem::Specification.new do |spec|
3132
spec.add_development_dependency 'database_cleaner', '~> 1.5'
3233
spec.add_development_dependency 'rake'
3334
spec.add_development_dependency 'rspec-rails', '>= 3.5'
34-
spec.add_development_dependency 'rubocop', '>= 1.8.0'
35-
spec.add_development_dependency 'rubocop-rails', '>= 2.9.0'
36-
spec.add_development_dependency 'rubocop-rspec', '>= 2.1.0'
35+
spec.add_development_dependency 'rubocop', '~> 1.23.0'
36+
spec.add_development_dependency 'rubocop-rails', '~> 2.12.0'
37+
spec.add_development_dependency 'rubocop-rspec', '~> 2.6.0'
3738

3839
spec.add_development_dependency 'sqlite3', '~> 1.3'
3940
end

spec/db/database.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# frozen_string_literal: true
2+
23
require 'fileutils'
34

45
database_folder = "#{File.dirname(__FILE__)}/../db"

spec/model/node_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def create_tree(max_level, current_level = 0, node = nil)
2424
expect(@root.children.count).to be(3)
2525
end
2626

27-
it 'does not include root node ' do
27+
it 'does not include root node' do
2828
expect(@root.children).not_to include(@root)
2929
end
3030
end

spec/values_spec.rb

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,16 @@
7272
end
7373

7474
context 'Relation' do
75-
subject(:value) { described_class.create(relation, OpenStruct.new(primary_key: :id)) }
75+
subject(:value) { described_class.create(relation, double) }
7676

7777
let(:relation) { Node.where(name: 'test') }
78+
let(:double) do
79+
Class.new do
80+
def self.primary_key
81+
:id
82+
end
83+
end
84+
end
7885

7986
it { is_expected.to be_a ActsAsRecursiveTree::Options::Values::Relation }
8087

0 commit comments

Comments
 (0)