Skip to content

Commit 2c0cb5b

Browse files
committed
feat: update module and tool delete APIs to use DefaultResultSerializer for responses
1 parent 7c15082 commit 2c0cb5b

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

apps/modules/api/module.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from drf_spectacular.utils import OpenApiParameter
44

55
from common.mixins.api_mixin import APIMixin
6-
from common.result import ResultSerializer
6+
from common.result import ResultSerializer, DefaultResultSerializer
77
from modules.models.module import ModuleCreateRequest, ModuleEditRequest
88
from modules.serializers.module import ModuleSerializer
99

@@ -84,7 +84,9 @@ def get_request():
8484

8585

8686
class ModuleDeleteAPI(ModuleReadAPI):
87-
pass
87+
@staticmethod
88+
def get_response():
89+
return DefaultResultSerializer
8890

8991

9092
class ModuleTreeReadAPI(APIMixin):

apps/modules/views/module.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from common.auth import TokenAuth
77
from common.auth.authentication import has_permissions
88
from common.constants.permission_constants import Permission, Group, Operate
9-
from common.result import result, DefaultResultSerializer
9+
from common.result import result
1010
from modules.api.module import ModuleCreateAPI, ModuleEditAPI, ModuleReadAPI, ModuleTreeReadAPI, ModuleDeleteAPI
1111
from modules.serializers.module import ModuleSerializer, ModuleTreeSerializer
1212

@@ -65,7 +65,7 @@ def get(self, request: Request, workspace_id: str, source: str, module_id: str):
6565
description=_('Delete module'),
6666
operation_id=_('Delete module'),
6767
parameters=ModuleDeleteAPI.get_parameters(),
68-
responses=DefaultResultSerializer,
68+
responses=ModuleDeleteAPI.get_response(),
6969
tags=[_('Module')])
7070
@has_permissions(lambda r, kwargs: Permission(group=Group(kwargs.get('source')), operate=Operate.DELETE,
7171
resource_path=f"/WORKSPACE/{kwargs.get('workspace_id')}"))

apps/tools/api/tool.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from drf_spectacular.utils import OpenApiParameter
44

55
from common.mixins.api_mixin import APIMixin
6-
from common.result import ResultSerializer
6+
from common.result import ResultSerializer, DefaultResultSerializer
77
from tools.serializers.tool import ToolModelSerializer, ToolCreateRequest
88

99

@@ -67,7 +67,9 @@ def get_request():
6767

6868

6969
class ToolDeleteAPI(ToolReadAPI):
70-
pass
70+
@staticmethod
71+
def get_response():
72+
return DefaultResultSerializer
7173

7274

7375
class ToolTreeReadAPI(APIMixin):

apps/tools/views/tool.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from common.auth import TokenAuth
77
from common.auth.authentication import has_permissions
88
from common.constants.permission_constants import PermissionConstants
9-
from common.result import result, DefaultResultSerializer
9+
from common.result import result
1010
from tools.api.tool import ToolCreateAPI, ToolEditAPI, ToolReadAPI, ToolDeleteAPI, ToolTreeReadAPI
1111
from tools.serializers.tool import ToolSerializer, ToolTreeSerializer
1212

@@ -60,7 +60,7 @@ def get(self, request: Request, workspace_id: str, tool_id: str):
6060
description=_('Delete tool'),
6161
operation_id=_('Delete tool'),
6262
parameters=ToolDeleteAPI.get_parameters(),
63-
responses=DefaultResultSerializer,
63+
responses=ToolDeleteAPI.get_response(),
6464
tags=[_('Tool')])
6565
@has_permissions(PermissionConstants.TOOL_DELETE.get_workspace_permission())
6666
def delete(self, request: Request, workspace_id: str, tool_id: str):

0 commit comments

Comments
 (0)