Skip to content

No functionality against Input_Finish is done in Sampling module 2 #13

@faayez-10xe

Description

@faayez-10xe

Issue Title
Issue Title: No functionality against Input_Finish is done in Sampling module 2
Problem Description
During the testing of Sampling module 2, there comes a run time error in module SamplingModule2. If sequence of a Finish is generated with value 1, it will still sample the inputs if in_valid is 1.

Expected Behavior
This code will produce run-time error which can only be detected by observing outputs and wave-forms.

Reasons Behind the Run-time Error
This run-time error is due to not having a check for Input_Finish signal in module SamplingModule2.

Proposed Solution
In file SamplingModule.v, where Rear Part of Module - Input part starts, there is a check for Input_Valid and Input_Reset, add there a check for Input_Finish.

image

There is another issue that Input_Finish, wherever it is being used in this hardware design, is not correctly working because it is not fully implemented.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions