Skip to content

Commit fdd67ea

Browse files
committed
unify string resources, cleanup translations
fixes spelling of OK, unifies all OK usages to one GEN_OK removes unused translations, including the DB upgrade notice Signed-off-by: Aron Heinecke <aron.heinecke@t-online.de>
1 parent 7b5f4cc commit fdd67ea

File tree

16 files changed

+21
-40
lines changed

16 files changed

+21
-40
lines changed

app/src/main/java/vocabletrainer/heinecke/aron/vocabletrainer/dialog/ImportLogDialog.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import android.support.annotation.Nullable;
66
import android.support.v4.app.DialogFragment;
77
import android.support.v7.app.AlertDialog;
8-
import android.util.Log;
98

109
import vocabletrainer.heinecke.aron.vocabletrainer.R;
1110

@@ -40,7 +39,7 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
4039
alertDialog.setTitle(R.string.Import_Finished_Title);
4140
alertDialog.setMessage(getArguments().getString(LOG));
4241

43-
alertDialog.setPositiveButton(R.string.GEN_Ok, (dialog, whichButton) -> this.dismiss());
42+
alertDialog.setPositiveButton(R.string.GEN_OK, (dialog, whichButton) -> this.dismiss());
4443
return alertDialog.create();
4544
}
4645
}

app/src/main/java/vocabletrainer/heinecke/aron/vocabletrainer/dialog/TrainerResultDialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
6464
alertDialog.setTitle(R.string.Trainer_Diag_finished_Title);
6565
alertDialog.setMessage(R.string.Trainer_Diag_finished_MSG);
6666

67-
alertDialog.setPositiveButton(R.string.Trainer_btn_ok, (dialog, whichButton) -> callFinishAction());
67+
alertDialog.setPositiveButton(R.string.GEN_OK, (dialog, whichButton) -> callFinishAction());
6868
return alertDialog.create();
6969
}
7070

app/src/main/java/vocabletrainer/heinecke/aron/vocabletrainer/dialog/VEntryEditorDialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
135135
tAddition.setSingleLine();
136136
tAddition.setText(addition);
137137

138-
builder.setPositiveButton(R.string.Editor_Diag_edit_btn_OK, (dialog, whichButton) -> {
138+
builder.setPositiveButton(R.string.GEN_OK, (dialog, whichButton) -> {
139139
List<String> mA = getMeanings(meaningsA);
140140
List<String> mB = getMeanings(meaningsB);
141141

app/src/main/java/vocabletrainer/heinecke/aron/vocabletrainer/dialog/VListEditorDialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
140140

141141
alertDialog.setView(view);
142142

143-
alertDialog.setPositiveButton(R.string.Editor_Diag_table_btn_Ok, (dialog, whichButton) -> {
143+
alertDialog.setPositiveButton(R.string.GEN_OK, (dialog, whichButton) -> {
144144
if (iColA.getText().length() == 0 || iColB.length() == 0 || iName.getText().length() == 0) {
145145
Log.d(TAG, "empty insert");
146146
}

app/src/main/java/vocabletrainer/heinecke/aron/vocabletrainer/fragment/ExportFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ private void checkInputOk() {
336336
alert.setCancelable(true);
337337
alert.setTitle(R.string.Export_Error_Format_Multivalue_Title);
338338
alert.setMessage(R.string.Export_Error_Format_Multivalue_Text);
339-
alert.setNeutralButton(R.string.GEN_Ok, (dialogInterface, i) -> {
339+
alert.setNeutralButton(R.string.GEN_OK, (dialogInterface, i) -> {
340340
formatWarnDialog = false; // clear state
341341
});
342342
alert.show();

app/src/main/java/vocabletrainer/heinecke/aron/vocabletrainer/fragment/FormatFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ private boolean verifyFormat(){
216216

217217
errorDiag.setTitle(R.string.Format_Diag_error_Title);
218218
errorDiag.setMessage(msg);
219-
errorDiag.setPositiveButton(R.string.GEN_Ok, (dialog, whichButton) -> {
219+
errorDiag.setPositiveButton(R.string.GEN_OK, (dialog, whichButton) -> {
220220
});
221221

222222
errorDiag.show();

app/src/main/res/layout/activity_file.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
android:layout_marginBottom="8dp"
6565
android:layout_marginEnd="8dp"
6666
android:onClick="onOkPressed"
67-
android:text="@string/File_btn_OK"
67+
android:text="@string/GEN_OK"
6868
app:layout_constraintBottom_toBottomOf="parent"
6969
app:layout_constraintLeft_toRightOf="@+id/bFileCancel"
7070
app:layout_constraintRight_toRightOf="parent" />

app/src/main/res/layout/fragment_export.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123
android:layout_marginLeft="8dp"
124124
android:layout_marginRight="8dp"
125125
android:layout_marginTop="8dp"
126-
android:text="@string/Export_Ok"
126+
android:text="@string/Export_OK"
127127
app:layout_constraintLeft_toLeftOf="parent"
128128
app:layout_constraintRight_toRightOf="parent"
129129
app:layout_constraintTop_toBottomOf="@+id/chkExportMulti" />

app/src/main/res/layout/fragment_import.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@
262262
android:layout_marginLeft="8dp"
263263
android:layout_marginRight="8dp"
264264
android:layout_marginTop="8dp"
265-
android:text="@string/Import_Ok"
265+
android:text="@string/Import_OK"
266266
app:layout_constraintLeft_toLeftOf="parent"
267267
app:layout_constraintRight_toRightOf="parent"
268268
app:layout_constraintTop_toBottomOf="@+id/rgImportMultiple" />

app/src/main/res/layout/fragment_list_selector.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
android:layout_marginBottom="8dp"
2525
android:layout_marginEnd="8dp"
2626
android:layout_marginStart="8dp"
27-
android:text="@string/GEN_Ok"
27+
android:text="@string/GEN_OK"
2828
android:visibility="visible"
2929
app:layout_constraintBottom_toBottomOf="parent"
3030
app:layout_constraintEnd_toEndOf="parent"

0 commit comments

Comments
 (0)