refactor: Update userStatsEmbed to return null on errors and include user roles in response

Author: 0-don

src/commands/user/user.ts

@@ -45,13 +45,14 @@ export class UserCommand {
         );
     }
 
-    const embed = await StatsService.userStatsEmbed(interaction, user);
+    const userStats = await StatsService.userStatsEmbed(interaction, user);
 
-    if (typeof embed === "string") return await interaction.editReply(embed);
+    if (typeof userStats?.embed === "string")
+      return await interaction.editReply(userStats?.embed);
 
     // return embed
     return await interaction.editReply({
-      embeds: [embed],
+      embeds: [userStats!.embed],
       allowedMentions: { users: [] },
     });
   }

src/lib/stats/stats.service.ts

@@ -104,11 +104,11 @@ export class StatsService {
     const memberId = user?.id ?? interaction.member?.user.id;
     const guildId = interaction.guild?.id;
 
-    if (!memberId || !guildId) return "Something went wrong";
+    if (!memberId || !guildId) return null;
 
     const embed = await StatsService.getUserStatsEmbed(memberId, guildId);
 
-    if (!embed) return "Something went wrong";
+    if (!embed) return null;
 
     return embed;
   }
@@ -132,7 +132,7 @@ export class StatsService {
       : null;
 
     // Execute all initial queries in parallel
-    const [lastVoice, lastMessage, helpCount, helpReceivedCount] =
+    const [lastVoice, lastMessage, helpCount, helpReceivedCount, userRoles] =
       await Promise.all([
         prisma.guildVoiceEvents.findMany({
           where: { guildId, memberId },
@@ -150,6 +150,10 @@ export class StatsService {
         prisma.memberHelper.count({
           where: { guildId, threadOwnerId: memberId },
         }),
+        prisma.memberRole.findMany({
+          where: { memberId, guildId },
+          select: { name: true, roleId: true },
+        }),
       ]);
 
     // Execute stats queries in parallel
@@ -196,7 +200,7 @@ export class StatsService {
       oneDayVoiceSum,
     });
 
-    return embed;
+    return { embed, roles: userRoles.map((role) => role.name) };
   }
 
   static async voiceStats(memberId: string, guildId: string, lookback: number) {